feat(TPG>=7.17)!: add support for node_drain_config #2535
Conversation
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
DrFaust92
changed the title
Summary of ChangesHello @DrFaust92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the management of Google Kubernetes Engine (GKE) node pools by integrating a new configuration option that allows for graceful node draining during deletion. This ensures that Pod Disruption Budgets (PDBs) are honored, minimizing service interruptions. Additionally, it updates the underlying Terraform Google provider versions to align with the latest capabilities and requirements. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for node_drain_config by introducing the respect_pdb_during_node_pool_deletion parameter for node pools. The changes include updating the Google provider version, adding the new configuration to the node pool resources, and updating the documentation. The implementation is functional and mostly correct. I've included some low-severity suggestions in the review comments to improve readability and maintain consistency, though these are not mandatory changes.
Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
DrFaust92
requested review from
a team,
apeabody,
ayushmjain,
ericyz,
krprabhat-eng and
q2w
as code owners
|
/gcbrun |
apeabody
left a comment
apeabody
left a comment
There was a problem hiding this comment.
Thanks for the contribution @DrFaust92!
2 participants
No description provided.